27 changesets created by SafwatHalaby_bot have been discussed with 5 replies of this contributor
Changeset # Tmstmp UTC Contributor Comment
53507357
by SafwatHalaby_bot
@ 2017-11-04 15:43
12017-12-28 13:13سامبا
♦28
The following node (http://www.openstreetmap.org/node/1803001720 and 1803001724) seemed not to be updated correctly, since name and name:ar differed. I manually corrected it.
22018-01-06 15:01SafwatHalaby
♦622
Thanks for the report. I'll look into it
32018-03-19 08:31SafwatHalaby
♦622
I have confirmed there are bugs in certain cases. This includes this, from the latest update: https://www.openstreetmap.org/node/1803036633

I will not run further gtfs updates until I fix the issue.
42025-06-23 22:56NeatNit
♦30
Congrats, SafwatHalaby of 7 years ago! You just broke gtfs2osm! 🥳

My code assumes that if a changeset has source=mot.gov.il then it's a GTFS import. In particular, it assumes that all updated bus stops have a ref tag. This doesn't hold for this stop: https://www.openstreetmap.org/nod...
53831421
by SafwatHalaby_bot
@ 2017-11-16 07:15
12017-11-16 07:18SafwatHalaby_bot ### Running script
ddx_del: 0
ddx_nothing: 1
dxd_create: 44
dxx_update: 0
xdd_nothing: 0
xdx_delete: 0
xxd_create: 0
xxd_nothing: 2
xxx_update: 27543
update: 27543
update_touched: 0
update_not_touched: 27543
update_distanceTooFar_skipped: 0
update_distanceTooFar_ignored: 0
create: 44\...
53649262
by SafwatHalaby_bot
@ 2017-11-09 20:03
12017-11-09 20:03SafwatHalaby
♦622
ddx_del: 0
ddx_nothing: 0
dxd_create: 10
dxx_update: 0
xdd_nothing: 0
xdx_delete: 0
xxd_create: 0
xxd_nothing: 0
xxx_update: 27546
update: 27546
update_touched: 31
update_not_touched: 27515
update_distanceTooFar_skipped: 0
update_distanceTooFar_ignored: 0
create: 10
del: 0
nothing: 0...
53621985
by SafwatHalaby_bot
@ 2017-11-08 20:43
12017-11-08 20:45SafwatHalaby_bot ddx_del: 0
ddx_nothing: 0
dxd_create: 31
dxx_update: 0
xdd_nothing: 0
xdx_delete: 1
xxd_create: 4
xxd_nothing: 0
xxx_update: 27511
update: 27511
update_touched: 2
update_not_touched: 27509
update_distanceTooFar_skipped: 0
update_distanceTooFar_ignored: 0
create: 35
del: 1
nothing: 0\...
22017-11-08 21:11SafwatHalaby
♦622
The 4 xxd_create stops are stops accidentally deleted by me manually prior to running this. I forced the bot to re-create them. Normally, the bot does not always recreate user-deleted stops.
49299149
by SafwatHalaby_bot
@ 2017-06-06 09:06
12017-06-06 09:40SafwatHalaby_bot Total names copies: 5967
Total name to name:en: 874
Total name:he to name: 0
Total name to name:he: 5093
Total name:ar to name: 0
Total name to name:ar: 0
Whitespace fixes: 638
Total scanned: 18528
Total unhandled errors: 203


http://www.openstreetmap.org/node/1803001097: name is not ar,...
22017-10-15 08:50zstadler
♦1,055
Hi SafwatHalaby,
.
In this edit, the bot copied numbered names to name:en. For example, http://www.openstreetmap.org/relation/2994312/history
.
Do you think it is useful?
32017-10-17 06:22SafwatHalaby
♦622
I don't think it's useful. I'll fix this.

Do you think it's useful?
42017-10-17 11:45zstadler
♦1,055
I agree, it is not useful.
Thanks for taking ownership on fixing it.
52162459
by SafwatHalaby_bot
@ 2017-09-19 05:41
12017-09-19 06:38SafwatHalaby
♦622
See the discussion at: https://www.openstreetmap.org/changeset/51350214
52162366
by SafwatHalaby_bot
@ 2017-09-19 05:36
12017-09-19 06:38SafwatHalaby
♦622
This changeset did not behave as expected. It was supposed to add brand:wikidata and operator:wikidata. Also, it only touched nodes and not ways. I was followed up with a fix: https://www.openstreetmap.org/changeset/52162459

52025378
by SafwatHalaby_bot
@ 2017-09-14 04:18
12017-09-14 04:22SafwatHalaby_bot Total names copies: 542
Total name to name:en: 108
Total name:he to name: 0
Total name to name:he: 420
Total name:ar to name: 2
Total name to name:ar: 12
Whitespace fixes: 9
50520193
by SafwatHalaby_bot
@ 2017-07-24 08:23
12017-07-25 06:40SafwatHalaby_bot Total names copies: 429
Total name to name:en: 213
Total name:he to name: 0
Total name to name:he: 172
Total name:ar to name: 4
Total name to name:ar: 40
Whitespace fixes: 5
Total scanned: 1184
Total unhandled errors: 746
50233725
by SafwatHalaby_bot
@ 2017-07-12 15:31
12017-07-12 15:40SafwatHalaby_bot Total names copies: 45
Total name to name:en: 6
Total name:he to name: 0
Total name to name:he: 35
Total name:ar to name: 0
Total name to name:ar: 4
Whitespace fixes: 0
Total autofix attempts: 586
Total autofix success: 372
Total autofix fail: 214
22017-07-12 15:53SafwatHalaby_bot Reverted: https://www.openstreetmap.org/changeset/50234092
50182253
by SafwatHalaby_bot
@ 2017-07-10 17:27
12017-07-10 17:28SafwatHalaby_bot Total full match modifications: 53
Total scanned: 15164
Total unmodified: 15111
22017-07-10 17:31SafwatHalaby_bot Replace Table:
"Наси Бен-Цви Avenue": "проспект Наси Бен-Цви",
"ХаНамаль": "ХаНамель",
"Заменхоф": "Заменгоф"
49881298
by SafwatHalaby_bot
@ 2017-06-28 08:09
12017-06-28 08:10SafwatHalaby_bot Total names copies: 50
Total name to name:en: 4
Total name:he to name: 0
Total name to name:he: 46
Total name:ar to name: 0
Total name to name:ar: 0
Whitespace fixes: 0
Total scanned: 872
Total unhandled errors: 807
49789569
by SafwatHalaby_bot
@ 2017-06-24 09:19
12017-06-24 09:26SafwatHalaby_bot branches modified: 1032
49768266
by SafwatHalaby_bot
@ 2017-06-23 11:26
12017-06-23 11:28SafwatHalaby_bot Total names copies: 77
Total name to name:en: 31
Total name:he to name: 1
Total name to name:he: 39
Total name:ar to name: 0
Total name to name:ar: 6
Whitespace fixes: 0
Total scanned: 927
Total unhandled errors: 838
49674056
by SafwatHalaby_bot
@ 2017-06-19 18:36
12017-06-19 18:38SafwatHalaby_bot This changeset's description has been wrongly named. It should be: Copied missing name tags and fixed whitespace.
22017-06-19 18:40SafwatHalaby_bot Total names copies: 356
Total name to name:en: 51
Total name:he to name: 6
Total name to name:he: 285
Total name:ar to name: 0
Total name to name:ar: 14
Whitespace fixes: 4
Total scanned: 1211
Total unhandled errors: 853
49673764
by SafwatHalaby_bot
@ 2017-06-19 18:22
12017-06-19 18:23SafwatHalaby_bot Total full match modifications: 411
Total scanned: 14307
Total unmodified: 13896


Replace table:
"Xa Наркис": "ХаНаркис",
"Xe Керем": "ХаКерем",
"Менделе Мохер Seforim": "Менделе Мохер ...
49548816
by SafwatHalaby_bot
@ 2017-06-15 06:24
12017-06-15 06:50SafwatHalaby
♦622
Total names copies: 9362
Total name to name:en: 2645
Total name:he to name: 1
Total name to name:he: 6092
Total name:ar to name: 92
Total name to name:ar: 532
Total unhandled errors: 337
49295375
by SafwatHalaby_bot
@ 2017-06-06 06:42
12017-06-06 06:48SafwatHalaby_bot Total full match modifications: 1098
Total scanned: 13576
Total unmodified: 12478
22017-06-13 08:25SafwatHalaby_bot Replace table: (Left: Old value. Right: New value)
{
"Xa Намал":"ХаНамаль",
"Xa кнессет":"ХаКнессет",
"Мордехай Anilevich":"Мордехай Анилевич",
"Xa Шофтим":"Ха...
49412690
by SafwatHalaby_bot
@ 2017-06-10 05:00
12017-06-10 05:13SafwatHalaby
♦622
Total names copies: 5479
Total name to name:en: 519
Total name:he to name: 0
Total name to name:he: 4861
Total name:ar to name: 0
Total name to name:ar: 99
Whitespace fixes: 1808
Total unhandled errors: 193
22017-06-13 05:42SafwatHalaby
♦622
The bounding box of this change was accidentally cropped from the top. Ashdod and Ashkilon were not edited despite being in the South district.
49295174
by SafwatHalaby_bot
@ 2017-06-06 06:35
12017-06-06 06:38SafwatHalaby_bot http://www.openstreetmap.org/way/127162070: name, name:he mismatch.
http://www.openstreetmap.org/node/4623086544: Has no name, name:ar, name:he, name:en, Has other languages.
http://www.openstreetmap.org/node/4735801768: name is not ar,he,en
http://www.openstreetmap.org/way/331226494: name, name:...
49225264
by SafwatHalaby_bot
@ 2017-06-03 17:28
12017-06-03 17:43SafwatHalaby_bot http://www.openstreetmap.org/way/69717186: name,name:he mismatch.
http://www.openstreetmap.org/way/137031570: name,name:he mismatch.
http://www.openstreetmap.org/node/4100370470: Missing name tag, multiple name:lang. Could not determine language.
http://www.openstreetmap.org/way/485640227: name,n...
49223571
by SafwatHalaby_bot
@ 2017-06-03 15:58
12017-06-03 17:16SafwatHalaby_bot http://www.openstreetmap.org/node/4461860190: name:en is not English.
http://www.openstreetmap.org/node/4102748607: name:en is not English.

http://www.openstreetmap.org/node/4741034222: Missing name tag, multiple name:lang. Could not determine language.
http://www.openstreetmap.org/node/4834615...
22017-06-03 17:38SafwatHalaby_bot Note: bounding box is bigger than the northern district due to relation edits. Future runs should have a good bounding box.
48621078
by SafwatHalaby_bot
@ 2017-05-12 11:28
12017-05-12 11:29SafwatHalaby
♦622
This edit was not made by a bot. I accidentally used the wrong user. Won't happen again.
22017-05-20 22:58Polarbear
♦941
Why did you remove the "emergency=no" tag from the hospital?
32017-05-23 07:19SafwatHalaby
♦622
Accident. Sorry. Added it back in https://www.openstreetmap.org/changeset/48908220

Thanks for the catch.
42017-06-02 07:24SafwatHalaby
♦622
Actually, this was not an error. Apparently they have an emergency department (and even a helipad which I presume is used in emergencies). http://www.gmc.org.il/Pages.aspx?pg=division&CategoryID=500&ID=45
52017-06-02 07:36SafwatHalaby
♦622
Fixed in https://www.openstreetmap.org/changeset/49187051
62017-06-02 08:51Polarbear
♦941
Seems to be fine now.
In general, however, do not "presume". Do not conclude "if there is feature X, there must be feature Y". Reality has exceptions. Check on the ground, and research objects individually.
That's why OSM is quite strict about mechanical edits.
thanks.
72017-06-02 09:34SafwatHalaby
♦622
1. The link explicitly states it has an emergency department.

2. This is not a mechanical edit. It was accidentally made in SwiftFast_bot
82017-06-02 10:42Polarbear
♦941
As said, everything fine with this CS.
My last comment was to be generally cautious with mech edits.
Take care, and thanks for the cooperation and discussion.
92017-06-02 12:02SafwatHalaby
♦622
Thank you :)

I find automation to be a very powerful drudgery saver, allowing mappers to work on what really matters. I am taking great care to document every step and to always start slow:

https://wiki.openstreetmap.org/wiki/User:SwiftFast#SwiftFast_bot
49171684
by SafwatHalaby_bot
@ 2017-06-01 17:19
12017-06-01 17:24SafwatHalaby
♦622
http://www.openstreetmap.org/node/4808049314: name,name:he mismatch.

http://www.openstreetmap.org/node/4808049315: Missing name tag, multiple name:lang. Could not determine language.

Total modifications: 115
Total name:en to name: 0
Total name to name:en: 28
Total name:ar to name: 0
Total ...
48920913
by SafwatHalaby_bot
@ 2017-05-23 15:50
12017-06-01 07:13SafwatHalaby
♦622
Reported here: https://forum.openstreetmap.org/viewtopic.php?pid=647483#p647483

by

tdctdctdc
48642657
by SafwatHalaby_bot
@ 2017-05-13 08:24
12017-05-20 23:08Polarbear
♦941
Why do you remove the oneway tag nationwide?
The wiki says "it is not wrong to add it explicitly", so you are performing a mechanical edit just for your own tagging preferences.
Has the mechanical edit been discussed in the community before, if so, where?
22017-05-23 10:05SafwatHalaby
♦622
It was not discussed. I took it for granted that no one would mind this since it's always implicit. Perhaps I shouldn't have. Would you like me to revert it?

32017-05-23 10:27SafwatHalaby
♦622
Reverted.
42017-05-23 12:25Polarbear
♦941
... in https://www.openstreetmap.org/changeset/48912907
Thanks a lot.
Keep in mind that mechanical edits often
- cover previous mistakes on some objects
- miss specific exceptions on individual objects
Thanks again.
48695896
by SafwatHalaby_bot
@ 2017-05-15 09:22
12017-05-15 09:28SafwatHalaby
♦622
Note: the source tag is incorrect. Sorry.