| Changeset | # | ⏱️ Last updated | Contributor | Comment |
|---|---|---|---|---|
| 145193604 by VolkerKrause @ 2023-12-16 18:34 ~ 2 years ago | 1 | ~ 2 years ago | trigpoint ♦2,808 | Fixing cuisine on a demolished:amenity.Did you even look at the other tags?Actually a note to say whats here now would have been more appropriate. |
| 83540929 by VolkerKrause @ 2020-04-14 14:34 ~ 6 years ago | 1 | ~ 6 years ago | dmlu ♦164 | Hello,I noticed you have been modifying a LOT of airports across the globe (and in multiple changesets).Is this a mechanical edit that was discussed somewhere? What datasource was used to compare the IATA codes?-> https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conductdmlu |
| 2 | ~ 6 years ago | alester ♦188 | Rather than simply deleting these tags, it would have been better to convert them to better ones where possible. For example, it appears that a lot of these had their ICAO code tagged under the IATA key, so the key just needed to be changed. While they may have been incorrect IATA codes, they were c... | |
| 3 | ~ 6 years ago | dmlu ♦164 | Example of a IATA / ICAO mixup: https://www.openstreetmap.org/node/6439888118/history | |
| 4 | ~ 6 years ago | VolkerKrause | Hi,these changes merely clean up syntactically invalid IATA codes, ie those not consisting of three upper-case letters. The changes themselves were done manually, although the list of errors was the result of code consuming this data. ~150 cases in total, not all submitted yet though, the remain... | |
| 5 | ~ 6 years ago | VolkerKrause | So, how to proceed from here? Should this changeset as well as the similar #83546052 be reverted? | |
| 6 | ~ 6 years ago | alester ♦188 | It's up to you. You can either revert all of the changes and then make the necessary corrections, or keep the data as-is and add back any data that had been removed but can be made correct. | |
| 7 | ~ 6 years ago | dmlu ♦164 | It could also make for a very interesting MapRoulette challenge ;) | |
| 8 | ~ 6 years ago | VolkerKrause | Changeset 83600172 should fix changeset 83546052 by adding FAA codes that were previously wrongly tagged as IATA codes. There are two other patterns in those changes I did not revert/fix: (1) FAA codes in the IATA field, but also already set in the FAA field (2) IATA codes derived from (also syntact... | |
| 9 | ~ 6 years ago | alester ♦188 | One example that I saw still hasn't been fixed:https://www.openstreetmap.org/node/1042023589In that case, a valid ICAO code had been incorrectly tagged in the IATA field, and then subsequently deleted entirely by you. This hasn't been fixed by your latest changeset. This is the kind of... | |
| 10 | ~ 6 years ago | VolkerKrause | Right, but please note that the above mentioned fix was for the second changeset (83546052), not for this one (83540929). The issue you mention is part of this changeset, and therefore not addressed yet. I just thought it would be prudent to verify first I was on the right track before going over al... | |
| 11 | ~ 6 years ago | VolkerKrause | Changeset 83656249 re-adds those removed codes that are actual ICAO/FAA codes for this changeset. What remains now are 5 cases where the codes turned out to be Canadian or Mexican local airport codes. For those I am unsure how to correctly re-add them, using "ref" or the above suggested &q... | |
| 12 | ~ 6 years ago | dmlu ♦164 | Hello,Thank you for addressing the "issue" in such a proactive manner and not just reverting everything! I would not use airport_code, as this tag is not used at all [1]. Using the ref key would be better suited, as this tag is widely used :)[1] https://taginfo.openstreetmap.org/sear... | |
| 13 | ~ 6 years ago | VolkerKrause | Done in changeset 83734763. If I'm not missing anything, this should address all the feedback.If so I have one last question: How should I proceed with the remaining IATA code issues? Those seem to fall into roughly 3 categories:(1) ICAO/FAA/other LIDs wrongly marked as IATA codes (ie. si... | |
| 14 | ~ 6 years ago | Sowa1980 Active block | Comment not displayed. To view it, please select the "Include blocked users" option. | |
| 83656249 by VolkerKrause @ 2020-04-16 15:17 ~ 6 years ago | 1 | ~ 6 years ago | chachafish ♦462 | Thank you for your work. Would Mule Creek Airport have an FAA code? I believe FAA codes are designated only inside the United States? |
| 2 | ~ 6 years ago | chachafish ♦462 | Also, I think the ICAO code for Naked Lady Ranch Airport must be incorrect. This looks like an FAA code only | |
| 3 | ~ 6 years ago | VolkerKrause | Thanks for reviewing this! I agree on both.Mule Creek seems to be a Canadian airport code instead, I got fooled by the FAA website finding it as an FAA code (https://nfdc.faa.gov/nfdcApps/services/ajv5/airportDisplay.jsp?airportId=CBS4). I don't know how to properly tag those though (there&... | |
| 4 | ~ 6 years ago | VolkerKrause | Both issue should be addressed by changesets 83734763 and 83735227 respectively. | |
| 5 | ~ 6 years ago | Sowa1980 Active block | Comment not displayed. To view it, please select the "Include blocked users" option. |