| Changeset | # | Tmstmp UTC | Contributor | Comment |
|---|---|---|---|---|
| 142298461 by davidfaure_bot @ 2023-10-08 10:22 | 1 | 2023-11-09 09:56 | zorglubu ♦341 | Bonjour,Pour info sur ce nœud https://www.openstreetmap.org/node/1805857783#map=19/46.09996/1.83834osmose suggère d'écrire opening_hours="...; 2023 Oct 10,Dec 14-15,18-22 off" plutôt que "; 2023 Oct 10,2023 Dec 14-15,2023 Dec 18-22 off"Bie... |
| 118120481 by davidfaure_bot @ 2022-03-05 10:20 | 1 | 2023-04-24 12:53 | zorglubu ♦341 | Bonjour,La syntaxe des horaires de cette postehttps://www.openstreetmap.org/node/8725850020est signalée erronée dans JOSM.J'avoue ne pas savoir conclure si c'est JOSM ou la donnée qui est en erreur, donc je te transfère ;-)Bien cordialement. |
| 2 | 2023-04-29 08:34 | Dfaurekde ♦9 | Bien vu, il faut repeter année et mois, 2022 Mar 07-08,10-11 devrait etre 2022 Mar 07-08,2022 Mar 10-11 Je corrige kopeninghours, ainsi que ce noeud. | |
| 96765674 by davidfaure_bot @ 2021-01-01 11:02 | 1 | 2022-12-24 06:24 | Josef73 ♦273 | Hello, is the "dr. Dickson Legoh, SpKJ" everyday open? |
| 112880455 by davidfaure_bot @ 2021-10-23 16:20 | 1 | 2021-10-23 19:41 | Lee Carré ♦665 | Smaller changeset areas, please: http://wiki.osm.org/wiki/Changeset#Geographical_size_of_changesets |
| 2 | 2021-10-24 09:03 | Dfaurekde ♦9 | OK, thanks for the feedback. Done and documented in https://wiki.openstreetmap.org/wiki/Import/FrenchPostOfficeOpeningHours#Data_Import_Workflow | |
| 3 | 2021-10-24 14:31 | Lee Carré ♦665 | Thankyou 🙂👍. | |
| 4 | 2021-12-25 21:49 | Lee Carré ♦665 | @DfaurekdeI was reminded of the discussion in http://www.osm.org/changeset/114157461 where a different idea was reached for how to handle large French changesets, which may be more (long-term) desirable (keeping workflows simple, while avoiding the problem encountered here). | |
| 112880412 by davidfaure_bot @ 2021-10-23 16:20 | 1 | 2021-11-25 09:51 | Carto'Cité ♦1,139 | Bonjour.J'ai remarqué sur la poste annexe de la gare Ermont-Eaubonne (https://www.openstreetmap.org/node/8491953720) que son tag opening_hours a pris la valeur "closed". C'est intéressant mais est-ce que ça signifie qu'il n'y a plus de poste ann... |
| 112880433 by davidfaure_bot @ 2021-10-23 16:20 | 1 | 2021-10-23 19:38 | Lee Carré ♦665 | Smaller changeset areas, please: http://wiki.osm.org/wiki/Changeset#Geographical_size_of_changesets |
| 2 | 2021-10-24 09:01 | Dfaurekde ♦9 | OK, thanks for the feedback. Done and documented in https://wiki.openstreetmap.org/wiki/Import/FrenchPostOfficeOpeningHours#Data_Import_Workflow | |
| 3 | 2021-10-24 14:31 | Lee Carré ♦665 | Thankyou 🙂👍. | |
| 101171587 by davidfaure_bot @ 2021-03-17 08:36 | 1 | 2021-03-17 16:59 | user_5359 ♦19,398 | Hello! I see the value Mo-Fr 06:00-18:00; Sa 06:00-18:00; Su 08:00-13:00 why not Mo-Sa 06:00-18:00; Su 08:00-13:00 ? |
| 2 | 2021-03-17 22:07 | Dfaurekde ♦9 | Right, that's a possible further simplification. I'm reviewing tons and tons of entries to make the data valid, not necessarily as short as possible (the software I wrote for this, doesn't do that).I'll change this one now that you pointed me to it :-) | |
| 101077981 by davidfaure_bot @ 2021-03-15 22:51 | 1 | 2021-03-16 17:51 | OSM_RogerWilco ♦723 | Hi,what's wrong with "Mo-Sa 06:00-21:00; Su,PH 08:00-21:00; Dec 24,31 8:00-14:00; Dec 25-26 off; Jan 01 off" (https://www.openstreetmap.org/node/893350297)? Check with https://openingh.openstreetmap.de/evaluation_tool/ is OK. |
| 2 | 2021-03-16 18:56 | Dfaurekde ♦9 | Hi,The evaluation_tool has some builtin tolerance. The actual spec has no support for "Dec 24,31", it's "Dec 24, Dec 31".See monthday_selector (where the comma is), monthday_range, and date_from in https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification#d... | |
| 3 | 2021-03-17 09:01 | OSM_RogerWilco ♦723 | Hi Dfaurekde,so, 'Dec 25-26' is ok, but 'Dec 25,26' is not. Hmm... ok. | |
| 98030732 by davidfaure_bot @ 2021-01-23 18:04 | 1 | 2021-01-23 20:13 | gabro00 ♦321 | Hi,Could you please check this node OH value?https://www.openstreetmap.org/way/283180059I used this tool to evaluate the string https://openingh.openstreetmap.de/evaluation_tool/If I remember correctly, the month modifier accepts only the time specifiers before any , (comma) or ; (semicolo... |
| 2 | 2021-01-23 20:48 | davidfaure_bot | Hello. The "Sa-Su 09:00-19:00" is supposed to be only during the time frame "May 01-Jun 15,Sep 01-30"? Then indeed both of our versions were wrong, a comma should be used. A space was incorrect, and semicolon means it's always open Sa-Su which seems unlikely. Sorry for not c... | |
| 3 | 2021-01-23 21:14 | gabro00 ♦321 | Thanks for the quick fix, yes.So the evaluation tool is buggy? Because now it thinks[1] the pool is open this weekend, which is unfortunately not true. It opens typically at 1st Mai.Same problem for the rest of the pools: https://www.openstreetmap.org/changeset/98027313[1]:https://openin... | |
| 4 | 2021-01-23 22:02 | davidfaure_bot | Oh. I see. Wow. Very unexpected. I'll research this further and come back to you. | |
| 5 | 2021-01-24 10:08 | davidfaure_bot | Actually I hadn't noticed but the JS evaluation_tool shouts loudly when using no separator. It does the intended thing, but it says the syntax is incorrect.And AFAICS it's not a bug (that a comma won't do the right thing), the spec says "Note that an additional rule does no... | |
| 97652068 by davidfaure_bot @ 2021-01-17 20:38 | 1 | 2021-01-18 10:18 | MKnight ♦910 | Please exclude "corrections" if months etc. is in syntax.for example: change of n7865991873 is maybe before and after correction wrong.But after correction the node is invisble for QA-Tools. |
| 2 | 2021-01-18 13:06 | Dfaurekde ♦9 | Are you sure that it's wrong?It wasJul-Sep: Sa, Su 10:00-12:30; Mo-Fr: 10:00-16:30and I removed the ":" after Mo-Fr.This is saying "open weekends in summer, and open week days all year". This seems pretty valid to me, doesn't it?Can you explain to me w... | |
| 3 | 2021-01-18 13:33 | MKnight ♦910 | No, it _can be_ (maybe) wrong. It can be, that Jul-Sep: is meant for all rules (including Mo-Fr), but the spec says: "no".I will comment the CS of the mapper who added this and we will see.P.s. I have done some years ago a very lot of corrections like this and found a very lot... | |
| 4 | 2021-01-18 15:15 | Dfaurekde ♦9 | OK, thanks. I see your point.But of course even entries with a valid syntax can be wrong when the person entering those misunderstands the spec (as would be the case here without the ":" after Mo-Fr, which is unrelated to the question of whether Jul-Sep was supposed to apply to everyth... | |
| 5 | 2021-01-18 19:07 | limes11 ♦890 | I agree that ":" was superfluous. Not sure if it causes an issue, but better to remove it.And indeed, the whole syntax was actually wrong. This place is open only in summer. | |
| 6 | 2021-01-18 19:20 | Dfaurekde ♦9 | Yes the ":" after weekday names isn't in the spec (https://wiki.openstreetmap.org/wiki/Key:opening_hours - see "weekdays") so there's no guarantee that all implementations will understand that syntax.Thanks for finding out about the correct value and fixing the attr... | |
| 7 | 2021-01-18 21:10 | MKnight ♦910 | "But of course even entries with a valid syntax can be wrong"Thats my Point. After the correction of the node, the Syntax is valid. And no QA-Tool can find it now for manual recheck. | |
| 8 | 2021-01-18 21:56 | Dfaurekde ♦9 | Imagine the initial value didn't have the ":" after Mo-Fr. It would still have been wrong (because in fact it's only open in summer) and it would still not have been in any QA tool.We can't just leave every minor syntax error out there, just in case there's an unrel... | |
| 97601011 by davidfaure_bot @ 2021-01-16 11:47 | 1 | 2021-01-16 23:33 | abakus_uploader ♦9,167 | (Wiadomość automatyczna)Cześć!Otrzymujesz ten komentarz, ponieważ dodałeś lub zmodyfikowałeś adres, który jest niepełny lub błędny.Adres powinien zawierać minimum trzy znaczniki: addr:city=[nazwa_miejscowosci] + addr:street=[nazwa_ulicy] + addr:housenumber=[numer_porz... |
| 2 | 2021-01-17 08:46 | Dfaurekde ♦9 | I did not modify any address, only the opening_hours attribute. | |
| 96776304 by davidfaure_bot @ 2021-01-01 15:27 | 1 | 2021-01-02 03:27 | jimkats ♦71 | If the owner of this bot reads the changeset comments, maybe you should change the source="survey", because it's not proper in this context, in my opinion. |
| 2 | 2021-01-15 21:51 | davidfaure_bot | Oops, you are completely right. This is a side effect of osm-bulk-upload/upload.py which defaults to survey if the -y argument isn't specified. I just submitted https://github.com/grigory-rechistov/osm-bulk-upload/issues/2 to signal this problem, and I'll fix my script. | |
| 3 | 2021-01-15 22:05 | davidfaure_bot | But actually, any good suggestion for the changeset source? The spec (https://wiki.openstreetmap.org/wiki/Key:opening_hours) ? The software (https://github.com/dfaure/OpeningHoursFixer) ? Or "extrapolation" ? | |
| 96777739 by davidfaure_bot @ 2021-01-01 16:00 | 1 | 2021-01-03 15:01 | Nakaner ♦3,149 | Dear operator of davidfaure_bot,according to the Automated Edits Code of Conduct, mechanical edits must be documented. However, I am not able to find any documentation at https://wiki.openstreetmap.org/wiki/Mechanical_Edits/davidfaure_bot because the page does not exist. Please comply with the g... |
| 2 | 2021-01-15 21:45 | davidfaure_bot | Hello,I had documented this edit at https://wiki.openstreetmap.org/wiki/Automated_edits/davidfaure_botShould this rather be in Mechanical_Edits? It's 90% automated, 10% manual since I review all changes before submitting them.This edit is based on the findings of the Osmose plugin for... | |
| 97293767 by davidfaure_bot @ 2021-01-11 09:22 | 1 | 2021-01-12 08:02 | KPull ♦35 | I believe this change is still incorrect. Shouldn't the comma before "Su" be a semi-colon? --- Published using OSMCha: https://osmcha.org/changesets/97293767 |
| 2 | 2021-01-12 21:37 | Dfaurekde ♦9 | Both are valid and in this case equivalent because the days are different. You can test it on https://openingh.openstreetmap.de/evaluation_tool/ | |
| 94950894 by davidfaure_bot @ 2020-11-28 16:08 | 1 | 2020-12-03 20:03 | Syl ♦961 | Bonjour, Osmose signale que ces horaires sont incorrects.Peut-être parce que "2021 Feb 16 off" est au milieu au lieu d'être à la fin. |
| 2 | 2020-12-03 20:18 | Dfaurekde ♦9 | Osmose se trompe, ces horaires sont corrects. C'est un bug Osmose, https://github.com/osm-fr/osmose-backend/issues/555Je suis sur le point de réécrire une nouvelle lib python pour remplacer le mauvais parseur utilisé par Osmose... | |
| 3 | 2020-12-04 01:11 | Syl ♦961 | Ok, merci pour ces précisions (et pour cet import !) |