26 changesets created by Ynhockey have been discussed with 23 replies of this contributor
Changeset # Tmstmp UTC Contributor Comment
50586762
by Ynhockey
@ 2017-07-26 11:53
12023-05-13 12:19zstadler
♦1,055
Hello,

In this edit you have changes the min_height of the saddlebrown building part
https://www.openstreetmap.org/way/510457003/history
from 89.1 to 80.24.

However, the height of the ivory building part https://www.openstreetmap.org/way/509856108/history remained 89.1.

As a result, there...
22023-05-13 17:42Ynhockey Hi, I have hopefully fixed it. I don't think there was an issue with the overlap per se, but some renderers might not know how to handle it, so I have made specific non-overlapping objects. Not having done 3D in a long time, it might not look good the first time, but I hope it will.
51036702
by Ynhockey
@ 2017-08-11 14:52
12023-05-13 07:49zstadler
♦1,055
Hi,

I see that you have done a great job in 3D mapping of buildings in Tel Aviv and elsewhere.

Could you please look again at the Saurasky Building at the Ichilov hospital?

1. The helipad has no min_/height tags, and it not rendered as a building part.

2. Changeset https://www.openstreet...
22023-05-13 17:30Ynhockey Hi Zeev,

From what I can see, I didn't change those values, but have added some stuff now. Unfortunately I wasn't able to easily find the blueprints for this building, and therefore don't know the heights for each element. It's also relatively difficult to estimate. For now I ...
48043243
by Ynhockey
@ 2017-04-22 20:00
12020-09-14 15:05zstadler
♦1,055
Hello Ynhockey,

In this edit you have added two lift gates:
http://www.openstreetmap.org/node/4810347107
https://www.openstreetmap.org/node/4810347108

However, these nodes are not part of any road and it's not clear what they are gating.

Could you put it on the relevant road/s or del...
22020-09-14 19:35Ynhockey It was too long ago to remember, it's probably a feature that exists in real life. Anyway, since I don't remember, I will delete them.
50388455
by Ynhockey
@ 2017-07-18 19:59
12019-07-08 10:43Sanniu
♦570
https://www.openstreetmap.org/way/348774405 - you have added "building:levels = t" that is the right number here?
22019-07-09 08:52Ynhockey Thanks, it was not deliberate. I have fixed the value.
65575796
by Ynhockey
@ 2018-12-18 09:55
12019-01-23 14:29Sanniu
♦570
https://www.openstreetmap.org/way/655889201 - is it roundabout?
59700642
by Ynhockey
@ 2018-06-09 22:04
12018-06-11 04:29SafwatHalaby
♦622
Hello Ynhockey! Your name change to https://www.openstreetmap.org/node/1803011231 (bus stop ref: 54) has been automatically reverted by the bus stop update script.
.
The reason behind this is explained in https://wiki.openstreetmap.org/wiki/User:SafwatHalaby/scripts/gtfs#Limited_name_tag_editing
57730249
by Ynhockey
@ 2018-04-02 06:57
12018-04-04 06:29Sanniu
♦570
Why to rename? Is there any official info that the hospital name was changed? And if so, old name should be preserved in tags - it's widely known in the area.
22018-04-04 06:51Ynhockey Hi, yes it's official, it has been a while so I felt that it's about time to rename. You are right about alternative names etc., most people still know it as Assaf HaRofeh and this is unlikely to change soon, similarly to how Rabin MC is still called either Beilinson or HaSharon. I will mo...
32018-04-04 06:53Ynhockey Also: there is an inconsistency in regards to hospitals in Israel, some have 'hospital' in the name while others don't. In Israel this is important because of all the bureaucratic terminology—so I think we should include that word as well.
54235855
by Ynhockey
@ 2017-12-01 13:28
12017-12-07 10:35Sanniu
♦570
End of HaMelacha is one-way dead-end now, also turn from HaMelacha to HaAmal is wrong way, can you check?
22017-12-07 11:28Ynhockey Hi, I think I have fixed it. Let me know if there is a problem.
32017-12-07 11:35Sanniu
♦570
Now it looks OK, thx!
48499750
by Ynhockey
@ 2017-05-08 11:53
12017-07-21 06:24zstadler
♦1,055
There seems that a new building added in this changeset:
.
http://www.openstreetmap.org/way/492103952
.
is overlapping an existing building:
.
http://www.openstreetmap.org/way/90828224
22017-07-21 10:54Ynhockey This is intentional: https://osmbuildings.org/?lat=32.07537&lon=34.78338&zoom=19&rotation=0&tilt=30
32017-07-23 07:40zstadler
♦1,055
Thanks! I didn't notice the "building:part" tag...
42017-10-25 19:32zstadler
♦1,055
Would it be possible to define this building part without using any node more than once (except for closing the way)?
.
The current shape creates a self-intersecting way.
.
https://wiki.openstreetmap.org/wiki/Self_intersecting_way_reports
52017-10-25 19:34Ynhockey It's possible, if the part is split into five. Can you point me to an explanation of why this is such a big problem though? The linked page only says it could be a problem. Why?
62017-10-25 21:14zstadler
♦1,055
The problem is when software tries to analyze the shapes in the map or store them in geographic databases that allow search. A self-intersecting polygon created issues.
.
For example, there is an error when reading this way to the search database for IsraelHiking.osm.org.il
.
To avoid self-inter...
72017-10-25 21:52zstadler
♦1,055
The shape in the previous comment got distorted.
.
Please see if http://www.openstreetmap.org/way/535361487 or something similar can replace http://www.openstreetmap.org/way/90828224
82017-11-03 23:26Ynhockey I have modified the building, hopefully it doesn't cause the same problems anymore.
92017-11-05 13:00zstadler
♦1,055
Thanks!
I appreciate your help!
39138876
by Ynhockey
@ 2016-05-06 09:21
12017-09-26 23:26zstadler
♦1,055
Hi,
.
In this edit you added http://www.openstreetmap.org/node/4169324780, but this gate is not connected to any footway or path.
.
Thanks!
22017-09-27 20:44Ynhockey I put a foot path there now, but don't remember which entrance exactly it connects to. Hopefully I am not in Beilinson again soon to find out!
32017-09-28 11:44zstadler
♦1,055
Thanks!
I've connected the footway to the nearest road. Further tuning can be done in the future.
49744816
by Ynhockey
@ 2017-06-22 11:57
12017-07-14 17:50Sanniu
♦570
https://www.openstreetmap.org/way/502668846 is not connected to anything else, thus excludes it from pedestrian routing, can you connect to surrounding streets, where appropriate?
22017-07-14 18:25Ynhockey Hi, I admit I don't use OSM for navigation, so things like that could occur in my changesets. I have added a number of new paths for this central square (it's accessible from all directions).
32017-07-14 18:27Sanniu
♦570
Thanks:)
34495247
by Ynhockey
@ 2015-10-07 17:01
12017-07-01 07:28Sanniu
♦570
http://www.openstreetmap.org/way/374335555 - is it roundabout?
22017-07-04 08:34Ynhockey Fixed.
34547830
by Ynhockey
@ 2015-10-10 11:59
12017-06-28 07:18Sanniu
♦570
http://www.openstreetmap.org/way/374691576 - is it roundabout?
22017-06-28 11:24Ynhockey Fixed.
32017-06-28 11:25Sanniu
♦570
thx
34411021
by Ynhockey
@ 2015-10-03 16:32
12017-06-28 07:19Sanniu
♦570
http://www.openstreetmap.org/way/373626689 - is it roundabout?
22017-06-28 11:25Ynhockey Fixed.
49230746
by Ynhockey
@ 2017-06-03 22:38
12017-06-28 07:17Sanniu
♦570
http://www.openstreetmap.org/way/497950274 - is it roundabout?
22017-06-28 11:25Ynhockey Fixed.
34691392
by Ynhockey
@ 2015-10-17 10:58
12017-06-28 07:13Sanniu
♦570
http://www.openstreetmap.org/way/375670258 - is it roundabout?
22017-06-28 11:25Ynhockey Fixed.
33511392
by Ynhockey
@ 2015-08-22 18:46
12017-06-18 08:56Sanniu
♦570
Kfar Ganim or Kfar Ganim A?
22017-06-23 19:36Ynhockey I think the neighborhoods are labeled separately in Hebrew: כפר גנים א, ב, ג. Should be reflected in English, I suppose.
32017-06-25 14:09Sanniu
♦570
Ok, fixed
15124277
by Ynhockey
@ 2013-02-22 14:34
12017-06-25 14:08Sanniu
♦570
https://www.openstreetmap.org/way/87793408 - מסדה or מצדה?
15303502
by Ynhockey
@ 2013-03-09 15:15
12017-06-14 05:26Sanniu
♦570
https://www.openstreetmap.org/way/155033064 is it יצחק למדן or הרב ירמה?
22017-06-14 10:10Ynhockey Good question. I haven't visited the area in a while, but according to all the other mapping services, Lamdan is the pedestrian footway between Rothschild and Krol. However, if that small street is Yerma, then it sort of doesn't make sense. Consider this (from Rothschild): https://www.goog...
49270772
by Ynhockey
@ 2017-06-05 13:34
12017-06-07 07:15Sanniu
♦570
http://www.openstreetmap.org/way/498294868 look like roundabout? Is it?
22017-06-07 08:51Ynhockey Thanks, I have added the tag.
48963792
by Ynhockey
@ 2017-05-25 06:24
12017-05-25 07:48SafwatHalaby
♦622
Hey, I'm not that familiar with 3d tagging, but according to the following Wiki page, all building:parts should be wrapped with a building outline: https://wiki.openstreetmap.org/wiki/Key:building:part

This does not appear to be the case e.g. here: https://www.openstreetmap.org/way/90843677
22017-05-25 09:50Ynhockey That method would be quite terrible, as it would create conflicts in the building outline. I am reading the page in the same way you are, but maybe they meant something else, because this method wouldn't work properly in any of the common renderers (like OSMBuildings, etc.). What does make sens...
32017-05-25 12:15SafwatHalaby
♦622
I don't know of any, and I don't know much about this in general.
48724513
by Ynhockey
@ 2017-05-16 08:57
12017-05-17 14:46Sanniu
♦570
It should be halt, not station in my opinion - no switches and other attributes of the station
22017-05-17 15:14Ynhockey I think all passenger stations in Israel should be labeled as station, because they all have significant infrastructure associated with them. The last "pirate" station with no entrance and no security was Yavne (east) afaik, until its renovation. We also don't have stations lacking a ...
32017-05-18 07:45Sanniu
♦570
Yeah, osm.org rendering is the strong point here. About service stations like Nahal Sorek I prefer to follow https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging#Employee_Station rules.
48477008
by Ynhockey
@ 2017-05-07 14:47
12017-05-10 10:57Ynhockey Hi Flayer, I am not sure why you removed part of the Midtown office tower building. Is there a particular reason? It's meant for the 3D display, in 2D it might look at bit awkward, but the angle was not an accident.
47816855
by Ynhockey
@ 2017-04-15 15:21
12017-04-16 07:56SafwatHalaby
♦622
Your changeset has overlapping buildings.
22017-04-17 09:20SafwatHalaby
♦622
My apologies. Appears to be a multi-level building. All good.
16856590
by Ynhockey
@ 2013-07-07 06:16
12017-01-24 11:06Sanniu
♦570
Way: 229036528 - no tags - what is it?
22017-01-24 15:24Ynhockey Fixed.
32017-03-27 10:02zstadler
♦1,055
Apparently, it was not fixed.
.
Way
http://www.openstreetmap.org/way/229036528
still has no tags.
24236555
by Ynhockey
@ 2014-07-19 11:11
12017-03-27 10:00zstadler
♦1,055
Way
http://www.openstreetmap.org/way/293403513
has no tags. What is it?