| Changeset |
No. |
Date |
Contributor |
Comment |
|
| 49549101 | marek kleciak | Stop destroying detailed map using generalization tools. In developing countries like Nepal eactly map can save human life. Please first ask, then act. |
| SomeoneElse | Hi Marek,Can you please explain what were the actual problems caused by this changeset and the others on which you have similarly commented?Also, you may find that that using emotive language such as "stop destroying" is less effective at communicating what you want to get across than ... |
| imagico | I would like to add that what bdiscoe did here was not in any way destroying a detailed map. He removed nodes which had a very little influence on the overall geometry because they were almost exactly in the middle between the next and the previous node. See http://nrenner.github.io/achavi/?change... |
| SomeoneElse | For info, see also https://www.openstreetmap.org/user_blocks/1385 . |
| bdiscoe | For what it's worth, I wrote OSM messages to marek kleciak explaining these edits, and even described the detailed steps he can do in JOSM to do the cleanup himself. |
| marek kleciak | We are in touch with bdiscoe now. I wrote him about reasons for this mapping. We have opportunity to make an very exactly example for nepali authorities and show the results during SOTM Asia 2017. All old, too less forest areas should be removed/modified. I hope for help of you all: The goal would b... |
| imagico | Who is 'we' here?Keep in mind that planning and organizing of mapping activities and development of mapping conventions should be public.Although there is not yet a formal policy on organized mapping activities it is good practice to document such activities and reference this in changeset c... |
| marek kleciak | We, is Kathmandu Living Maps. As you probably know from german forum I do a lot for Nepal and try to inform communities in Germany and Poland about recent situation there.What you wrote about mapping activities is a part of old OSM communication problem, but you´re absolutely right, I should... |
|
| 47241744 | de vries | Hi bdiscoe,I need to ask you to be more careful with edits like these. In this changeset you seem to have targeted BAG buildings for mass simplification. The methods and software used for importing and actualization of the BAG data has been discussed in great length. So doing mechanical edits to t... |
| bdiscoe | Hi, if you take a close look, you will see that no "details" were removed. As part of other cleanup (maproullette farm->farmland), I've been run the JOSM validator on some of the nearby buildings and landuse, and tidying up the results. The BAG buildings have numerous issues (including... |
| bdiscoe | For what it's worth, I recognize unlike other mass imports I'd had to clean up (Canvec, NHD, Tiger...) this data is much better in precision as well as accuracy. That's why i use thresholds not of 70-110 cm as with NHD, but as little as 6 cm for BAG, guaranteeing that cleanup stays within the accur... |
| bdiscoe | For an example of BAG problems, see buildings like http://www.openstreetmap.org/way/277899879 which has a "sliver" which is 18cm wide and 3m long; it is clearly a mechanical error. I have manually fixed hundreds of these problems. |
| Commodoortje | Hi bdiscoe,Thank you for fixing the JOSM validation errors on BAG import here.The person who did the BAG import is responsable for fixing duplicated nodes/crossing buildings/building inside building self-intersecting ways etc... |
| de vries | You had me at "I am an expert at what I'm doing". But if you want an example: compare this two images:http://pix.toile-libre.org/?img=1493650984.pnghttp://pix.toile-libre.org/?img=1493651063.pngThe imagery resolution is 7,5 cm so your simplification is nowhere within the accuracy of ... |
| Commodoortje | Het lijkt erop dat bdiscoe in JOSM de functie "Simplify Way" gebruikt.Wat deze tool doet: de contouren ontdoen van onnodige nodes.https://josm.openstreetmap.de/wiki/Help/Action/SimplifyWay.Ik ben het met de vries eens dat dit niet structureel op gebouwen mag plaatsvinden. Dan wordt... |
|
| 40298587 | bdiscoe | Hi there, many of the ways in this changeset are EXTREMELY overnoded. When you upload, you need to check the data FIRST for this problem and solve it before uploading. Otherwise it creates 26903 nodes in the OSM database, then someone has to come along afterwards and clean it up by deleting ~90% o... |
| bdiscoe | Example: before: http://i.imgur.com/HuJTxvi.pngAfter: http://i.imgur.com/VDAa6uE.pngNotice how the nodes for the selected are reduced from 1832 to 241, without affecting the accuracy of the data at all. |
|
| 39057659 | bdiscoe | Yes, it's NHD. Welcome to my world, Jeopardy. I've spent much of the last 6 months of my life cleaning up North Carolina's NHD (outdated wetlands just like these here in Florida). It's just a huge task, thanks for helping! |
| Harry Wood | The messiness of the data seems to be echoed by the messiness of the wiki page which is supposed to describe the dataset and the import process/status http://wiki.openstreetmap.org/wiki/National_Hydrography_Dataset |
| JeopardyTempest | Good to know :-)Though it seems the wetlands are at least proximate... we also seem to have a messy import of a church dataset with scattered nonexistent churches that seems more problematic.So what do you guys do to clean them up? If there's development over what used to be wetlands, I'll ... |
| bdiscoe | To answer your last question, Yes. |
|
| 38886799 | bdiscoe | Rps, there are some serious issues with this import. For example, consider way http://www.openstreetmap.org/way/413668789 It is "water", but unclosed. It is also duplicated, as is all the other sections of water which should have been joined here. PLEASE stop importing millions of featu... |
| Rps333 | Hi, thanks for pointing it out. The JOSM validation did not pick that out. I will clean them up. cheers |
| bdiscoe | When I load a small area around this feature, the JOSM validator reports "Errors: Duplicated ways (98), Duplicated nodes (s), Warning: natural type water - Unclosed way (46)" |
| bdiscoe | Rather than import huge amounts (>500K changed features on the day of this changeset!), I'd strongly recommend doing smaller sections (like ~10K features/day) so you can check it for errors _before_ uploading, thanks. |
| bdiscoe | It's two days later, and JOSM in this area still reports errors unclosed ways. Please fix your import before importing any more, thanks. |
| Rps333 | Hi I have been checking the JOSM again and for what ever reason JOSM is not finding the errors. I am pretty sure most of the errors are on the edge of the AOI that I downloaded from NRCan. I will try checking with another version of JOSM and a different PC. |
|
| 36059321 | bdiscoe | Hello Davaadulam, I see you changed the english name (name:en) of this street from "Olympic Avenue" to "Олимпийн өргөн чөлөө". The English name is actually "Olympic Avenue, correct? Why did you change it? |
|
| 35717824 | bdiscoe | Kendall, you added ways which should be paths or service roads, but you tagged them as "motorway" with names like "I-40 West" which is very odd and confusing. I will attempt to fix the tagging, but what did you intend here? |
|
| 35543670 | gileri | Thank you, this looks like a good thing to do !May I ask how did you do it with JOSM ? |
| bdiscoe | In the preferences, under "advanced", there is a setting called "simplify-way.max-error". It is important to set this to a low number appropriate for the specific geometry; in the case of a very clear lake like this, sub-meter precision can be maintained, hence a value of 0.4 |
| gileri | Thank you ! |
|
| 34831985 | bdiscoe | Testing ability to put emojis in chageset comments: 👍🏻👍🏼👍🏽👍🏾👍🏿😊😄😊 |
| bdiscoe | 👍 |
|
| 21830388 | bdiscoe | Maykel, you used "service" incorrectly for the roads in the village. They are "residential" roads. |
| bdiscoe | Also, where two roads cross, they need to share a node. Please learn about connectivity. |
|
| 31761407 | bdiscoe | Albert, you damaged the main Pinrang-Rappang highway by incorrectly changing the secondary to a service road. I will fix it now, but please be careful in the future. |
| bdiscoe | Also, never name roads just "jalan". The name tag is only for the actual name of the road, e.g. "Jln Poror Pinrang-Rappang" |
|
| 30944854 | maraf24 | Is this tag removal and transformation discussed with polish community? |
| bdiscoe | Hi maraf24, I believe I only removed a few tags, which were uncontroversially incorrect or extraneous. If there is a page that describes the Wroclaw building import, please direct me to it. |
|
| 30528688 | trigpoint | HiI have spotted that you have edited the River Severn in Shropshire.The river forms parts of Montford/Ford parish boundaries and in moving the river flow you have moved the boundaries so that they no longer follow the official lines.I am not sure what source you used to determine the main flo... |
| bdiscoe | Hi tngpoint, mostly this changeset was fixing the riverbanks and adding the islands. The centerline moved only very slightly; it had a few places where it did not appear to correspond to the river flow. I did the best I could using the aerial, but if you have better local knowledge, please feel fre... |
| bdiscoe | Also, I notice that it isn't quite consistent; in some places the parish boundaries share a way with the river, in other places they use two separate ways; perhaps someone determined that on that stretch the "official" boundary differed significantly enough from the river. Some boundaries... |
| SomeoneElse | I've always wondered (where boundaries follow rivers) exactly how those boundaries are defined, given that rivers move? In this case is there a text description that says something like "follows the centreline of the river from blah to blah", or is it defined in terms of exact coordinates... |
| bdiscoe | @SomeoneElse, it depends :) In some places the legal boundary is defined as the river, in other places the river was surveyed and that description of the course defined as legal boundary. It takes local knowledge to know the difference in different parts of the world. |
| trigpoint | The boundaries are taken from the latest OS Boundaryline, so can be assumed to indicate the official boundaries.I part way through a project to add the Shropshire parish boundaries, some sections of the Severn have yet to be joined to the parish boundaries.I am not sure how "the main flow&q... |
|
| 31027498 | maraf24 | With over 30000 deleted nodes this is certainly a mechanical edit.http://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct |
| bdiscoe | I reviewed it personally. There is decimation to remove noise and redundancy, but I also go over what remains manually to compare it to the aerial; many of these wetlands are no longer here and are adjusted accordingly. |
|
| 24336845 | bdiscoe | This looks like a building import, but there were already buildings there. Was there no attempt to integrate and check for overlaps? Is there a plan to clean this up, or should I go ahead and clean it up manually? |
| bdiscoe | I've proceeded to clean it up now. |