| Changeset |
No. |
Date |
Contributor |
Comment |
|
| 47952755 | LeTopographeFou | Bonjour, je vois que les passages piétons et chemins piétons ont été indiqués comme rue piétonnes (highway=pedestrian). Je trouve personnellement highway=footway plus approprié, le wiki tendant à confirmer cela. Je ne parle pas des terres plein... |
| althio | J'ai déjà eu une discussion à ce sujet (en privé) avec un autre contributeur. On peut discuter ici sur un changeset, mais aussi basculer sur le forum si cela t'intéresse. http://forum.openstreetmap.fr/viewtopic.php?f=18&t=5614 Voici ma lecture des pag... |
|
| 42881021 | LeTopographeFou | Hi, you used access=permissive but according to the wiki access=private would better fit as soon as the airport is not open to general traffic. What do you think? |
| LeTopographeFou | Modified to access=private in https://www.openstreetmap.org/changeset/47007664 |
|
| 20621797 | LeTopographeFou | Bonjour, je comprend que l'emprunte soit bien des immeubles (d'où le correctif), mais les immeubles sont-ils complétement des boutiques ? Tous les étages ? Il me parait plus juste de conserver les bâtiments actuels (mais remplacer building=retail par building=yes) et mettr... |
| Jepau | Bonsoir, votre proposition fait sens. Je m'étais simplement attaché a faire réapparaître les bâtiments qui avaient disparu de la carte. Vous avez très probablement raison sur le fait que les commerces sont au rdc et non pas sur la hauteurs des immeubles. Je vo... |
| LeTopographeFou | Ok merci, cf. https://www.openstreetmap.org/changeset/46031362 |
|
| 44244894 | SomeoneElse | Hello, You've merged together various "estate_agents", "estate_agency" etc. in here. I can see the logic in this, except that you've ignored the main tag of "shop" or "office" and made them all "office". I've certainly used both "shop" ... |
| LeTopographeFou | Hi SomeoneElse,Yes I see your point and I've followed a little bit the comments about shop vs office for this kind of business. What do you propose? I'm afraid that I will not be able to make the difference between those two as I'm not from England and can't check by myself. |
| SomeoneElse | > What do you propose?I'd change the ones that were shop previously (like http://www.openstreetmap.org/way/351521115/history ) back to shop, and if any of them had other tags that were changed into "office" at the same time, I'd change those back too. |
| LeTopographeFou | Done, all previously tagged shops have been redefined as shop. See https://www.openstreetmap.org/changeset/45980978 |
|
| 45869506 | LeTopographeFou | See also https://wiki.openstreetmap.org/wiki/Automated_edits/LeTopographeFou#.23004_-_TyposThinking afterwards, this edit may have been too agressive... I hope it will not be perceived this way. |
| SomeoneElse | I wouldn't say "aggressive", but I would say "irrelevant" - anything that parses mph speed limits is going to parse "30mph".Also, this change is making the tidying up of some earlier problem edits much, much harder. |
| LeTopographeFou | Yes I agree with your second sentence to better answer your first point: "30 mph" is different from "30mph" exactly because parsing (and regular expressions) can't save everyone, everywhere and everytime. This is why this is relevant at the end. Having a consistent data set helps... |
| SK53 | The idea that by editing tags to some kind of common format will somehow make it easier for data consumers is a pernicious fallacy. Any use of a speed limit with or without "mph" in the tag will require some form of parsing, error detection and data wrangling. For instance the 11th com... |
|
| 45958705 | LeTopographeFou | https://wiki.openstreetmap.org/wiki/Automated_edits/LeTopographeFou#.23006_-_Choose_of_a_wrong_tag |
|
| 44033095 | LeTopographeFou | Hi, way 456578120 has no tag. Can you please fix this issue? |
| Meersbrook | I used the polygon to create a shape. Some of the vertices have assigned roles. |
| LeTopographeFou | Ok but then the "shape" shall have tags, otherwise it means nothing. I assume you draw it from an existing real feature, so I'm sure there is a way to tag it, even with a note or fixme only. I don't want to delete it but I know there are bots/people which may delete it, so the best is prob... |
| Meersbrook | You can delete it, it's nothing that can't be redrawn if necessary. |
|
| 42808712 | LeTopographeFou | Hi, actually you put maxspeed="source:maxspeed=DE:zone30" instead of source:maxspeed="DE:zone30". Can you please fix the issue? |
| LeTopographeFou | Moreover I wonder if maxspeed="DE:zone30" should not be the right tag to put instead of source:maxspeed |
|
| 45474443 | LeTopographeFou | Hi Artus92 and welcome to OSM!It looks like you've created two empty areas (468728257 and 468728256). I assume this is an error. Can you please explain the purpose? I can delete them for you if you are not yet confident with the tools. |
|
| 44244656 | SomeoneElse | What were the usage statistics on "shop=candle" and "shop=candles" before you changed e.g. https://www.openstreetmap.org/node/4401825186/history ? |
| SomeoneElse | You might also want to double-check the spelling of the "Yankie" in here too, or check with the original mapper. |
| LeTopographeFou | Hi, since only "candles" is documented on the wiki and was mostly used, I pick this one to consolidate the use of this type of shop. A bit of math: there was 37 shop=candle vs 102 shop=candles. Reguarding "Yankie" I decided to focus this type of mass edit to the bare minimum, i.e... |
| SomeoneElse | Thanks for that. I'll have to add "candles" to https://github.com/SomeoneElseOSM/SomeoneElse-style/blob/master/style.lua . |
|
| 43414496 | LeTopographeFou | Hi @Claumires, is it normal that this changeset has deleted lot of ways and buildings I've drawn in this area ? I don't see any interest to remove them. |
|
| 186743 | LeTopographeFou | Hi,Most (if not all) of those gas stations have opening_hours=Sa-Su 24/7 which means that:1. the gas stations is opened only on Saturday and Sunday (which looks strange nowadays)2. There is a conflict because "24/7" means that it is open 24 hours a day 7 days a week (and not only o... |
|
| 38932583 | LeTopographeFou | Bonjour,Concernant les lampadaires, il y a deux soucis :1. Mauvais formatage des horaires, il faut mettre 18:00-05:30 pour que tous les outils puissent reconnaitre cette valeur2. Mauvais tag, il faut utiliser lit au lieu de opening_hoursCe qui donne donc lit=18:00-05:30.Pouvez-vous s... |
|
| 38933151 | LeTopographeFou | Bonjour,Concernant les lampadaires, il y a deux soucis :1. Mauvais formatage des horaires, il faut mettre 18:00-05:30 pour que tous les outils puissent reconnaitre cette valeur2. Mauvais tag, il faut utiliser lit au lieu de opening_hoursCe qui donne donc lit=18:00-05:30.Pouvez-vous s... |
|
| 34479372 | aseerel4c26 | Hi LeTopographeFou, could you please comment on the relation of your changeset with https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct ? |
| gormo | ...especially on "Document and discuss your plans". Where is the documentation? Was there a discussion? |
| aseerel4c26 | umm, there are much more similar changesets by LeTopographeFou. Where is the discussion for those changes? |
| aseerel4c26 | ... I've wrote a notification mail. |
| aseerel4c26 | ... and the DWG is aware too |
| LeTopographeFou | Thanks for your care aseerel4c26. Because the type=broad_leaved has been declared as deprecated on the Wiki, on TagInfo, and in JOSM (where I've had more than once warnings on this fact), I did not feel the need to open any discussion with the community neither to create any page to document a fact ... |
| fkv | The automated edits code of conduct does not depend on whether a tag is "deprecated". So-called deprecated tags are not necessarily wrong. First of all, many deprecations are done by single users who edit the wiki without prior discussion. Even if a formal proposal has been accepted by vot... |
| SomeoneElse | @fkv When I looked at the changes in here back in October last year I didn't see any evidence of data loss (though I only looked at a sample of the 5341 nodes). Whilst a change like type=broad_leafed => leaf_type=broadleaved should have been discussed beforehand, in case someone was aware of a... |
| fkv | Just take the first few nodes in this changeset as examples. They are located on Plaza de la Ciudad de la Habana, where there are palms and other trees. The non-palms were changed from type=broad_leafed (old spelling variant, but that's another issue) to leaf_type=broadleaved, losing the information... |
| LeTopographeFou | Hi, this changeset was made a long time ago and I thought it has been reverted (with some others of the same type and of the same period). I'm going to ask for a revert by mail if it is still feasible. |
| SomeoneElse | @fkv thanks; I wasn't aware of the use of "type" as meaning "not a palm tree".@LeTopographeFou thanks; I've got the message requesting a revert. Before doing it I'll ask around to see if there's any better way to indicate "not a palm tree". As I understand it (fro... |
| fkv | I was asking for a revert, but it might be better to restore the type=* tags while keeping the leaf_type=* tags. It does not hurt to have both.You could use taxon=* to mark palms, but there is no single taxon that includes all non-palm broad-leaved trees. Eudicots would be missing magnoliids, Aust... |
| SK53 | I tend to agree with @fkv on all issues: 1) large scale updates often have unpredictable side effects; 2) originally we distinguished between conifers/dicots aka broad-leaved and palms (and possibly one or two others) using a range of tags wood/type etc. Ultimately these have been replaced by leaf_t... |
| SomeoneElse | OK, done: See https://www.openstreetmap.org/changeset/41192016 . |
| LeTopographeFou | @SomeoneElse: Thank you! |
|
| 35653117 | trigpoint | HiAre you sure that when you surveyed http://www.openstreetmap.org/node/2030692588/history it was a speed limit sign? A truvello is normally a speed camera, but you would have noticed that along with the only 80kph speed limit sign in the UK?I am sure this was a mistake, because making an undisc... |
| chillly | This is an undiscussed mass edit.Please revert it now. |
| SomeoneElse | This changeset has been reverted in https://www.openstreetmap.org/changeset/35675358 .LeTopographeFou, please do not make further mass edits like this. As you have found out from the comments that other mappers have made on your most recent changes, it's very easy for you to misunderstand what ... |
| LeTopographeFou | Hi, Thank you for the revert SomeoneElse. No excuse for my defense, I have bitten off more than I can chew whithout understanding that by fixing tags I was introducing errors in some of them.Reguarding the node Trigpoint pointed out, after an OSM/Bing/Google Maps survey it appears that this node i... |
| SomeoneElse | Of course; we can't use Bing Maps or Google Maps for copyright reasons :)However, in this case I can confirm that the speed limit on the A45 (at least the other side of Ryton on Dunsmore a couple of years ago) was indeed 50 mph. However maxspeed=80 (in km/h) is of course the same as "mapspee... |
|
| 34414132 | SomeoneElse | What role should https://www.openstreetmap.org/way/239796445 have within https://www.openstreetmap.org/relation/1074897 ? Is it an inner, or something else entirely? |
| LeTopographeFou | Don't know, This changeset is only about replacing deprecated properties. This relation already existed before. You should ask directly in the page of this way/relation. |
|
| 34428457 | didier2020 | c'est plutot UnQuality Assurance on trees :nodes with tag leaf_type=broadleavedcomme celui-la : https://www.openstreetmap.org/node/2640855577 |
| SomeoneElse | @LeTopographeFou - are you going to correct the errors that you've introduced in this changeset (as identified by didier2020 ) or do you need help doing so? Please also do reply to the changeset discussion on https://www.openstreetmap.org/changeset/34479372 .Best Regards,Andy Townsend (SomeoneE... |
| LeTopographeFou | I don't understand what didier2020 expects from me and where I have introduced any error. I only understand that I should have commented better m'y changeset. |
| didier2020 | en regardant l'historique ce node:https://www.openstreetmap.org/node/2640855577/historyon voit que tag leaft_type=boradleveled a été ajouté dans ce changeset, alors que seul le way aurait du être modifié. |
| LeTopographeFou | Ok, thank you for the fix |